Skip to content

🏃 golangci-lint: use revive instead of golint linter#710

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
mythi:use-revive-linter
Jul 28, 2022
Merged

🏃 golangci-lint: use revive instead of golint linter#710
k8s-ci-robot merged 1 commit intokubernetes-sigs:masterfrom
mythi:use-revive-linter

Conversation

@mythi
Copy link
Contributor

@mythi mythi commented Jul 26, 2022

test.sh triggers a warning:
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The
repository of the linter has been archived by the owner. Replaced by revive.

Change the script accordingly.

@mythi
golangci-lint: use revive instead of golint linter
ebeb7bc 
test.sh triggers a warning:
WARN [runner] The linter 'golint' is deprecated (since v1.41.0) due to: The
repository of the linter has been archived by the owner.  Replaced by revive.

Change the script accordingly.

Signed-off-by: Mikko Ylinen <mikko.ylinen@intel.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 26, 2022

Hi @mythi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy July 26, 2022 10:39
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2022
@varshaprasad96
Copy link
Member

varshaprasad96 commented Jul 26, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2022
@FillZpp
Copy link
Contributor

FillZpp commented Jul 27, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@camilamacedo86
Copy link
Member

camilamacedo86 commented Jul 28, 2022

/approved

camilamacedo86
camilamacedo86 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@camilamacedo86
Copy link
Member

camilamacedo86 commented Jul 28, 2022

Hi @mythi,

I think we need to also update Kubebuilder. Could you help us out push the Pr so we do the updates there?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, camilamacedo86, mythi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8a80a3b into kubernetes-sigs:master Jul 28, 2022
@mythi
Copy link
Contributor Author

mythi commented Jul 31, 2022

I think we need to also update Kubebuilder. Could you help us out push the Pr so we do the updates there?

@camilamacedo86 looks like kubebuilder is already using revive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

+1 more reviewer

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@FillZpp FillZpp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mythi @k8s-ci-robot @varshaprasad96 @FillZpp @camilamacedo86 @alvaroaleman